Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: refactor keycache implementation to reduce duplication#15100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sreya merged 7 commits intomainfromjon/refactorcache
Oct 16, 2024

Conversation

sreya
Copy link
Collaborator

@sreyasreya commentedOct 16, 2024•
edited
Loading

This PR consolidates theDBKeycache andWSProxyCache into thecache type while retaining the implementation fromWSProxyCache. The function signatures have been updated to be compatible with the interfaces injwtutils. If I'm being honest I'm not particularly satisfied with how the API for this turned out but I figured that's what PRs are for.

Fixescoder/internal#91

Copy link
Contributor

@spikecurtisspikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is a nice refactor! Very clean. Some suggestions / questions inline, but I don't need to review again.

sreya reacted with heart emoji
@sreyasreya merged commitf537193 intomainOct 16, 2024
26 checks passed
@sreyasreya deleted the jon/refactorcache branchOctober 16, 2024 19:01
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 16, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@spikecurtisspikecurtisspikecurtis approved these changes

Assignees

@sreyasreya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor key caching to consolidate implementations
2 participants
@sreya@spikecurtis
[8]ページ先頭
©2009-2025 Movatter.jp