- Notifications
You must be signed in to change notification settings - Fork925
fix: correct connection_median_latency_ms in query#15086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -661,7 +661,7 @@ WITH | |||
| AND date_trunc('minute', was.created_at) = mb.minute_bucket | |||
| AND was.template_id = mb.template_id | |||
| AND was.user_id = mb.user_id | |||
| AND was.connection_median_latency_ms >= 0 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is the bug fix, in other queries that useconnection_median_latency_ms we always filter our the 0 values to rule out any usage stats.
| -- The greater than 0 is to support legacy agents that don't report connection_median_latency_ms. | ||
| WHERE workspace_agent_stats.created_at > $1 AND connection_median_latency_ms > 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is another fix I found along the way where we weren't filtering out the stats with 0 or selecting only recent stats.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice catches!
5f640eb intomainUh oh!
There was an error while loading.Please reload this page.
Closes#14805