Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: example: update docker-local to use host-gateway#1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 3 commits intomainfromcj/gh-1345/example-docker-host-gateway
May 17, 2022

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedMay 17, 2022
edited
Loading

This PR attempts to reduce the friction to getting a workspace up and running in docker when running Coder viadocker-compose using the exampledocker-local template:

  • docker-compose.yaml: pass through docker socket and set CODER_ACCESS_URL env
  • examples/docker-local: add host.docker.internal to containers

See:#1345

Copy link
Member

@mafredrimafredri left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Very smooth!

Not necessarily in this PR, but I think we still want to document the setup steps?

cd /path/to/coder/repodocker-compose up -dcoder login http://localhost:7080 # Create first usercoder templates create -d ./examples/docker-localcoder create dev

We could try to make some of them part of the compose file, perhaps it'd also be nicer todocker-compose run coder login ... to avoid having to install the binary.

…CONNECTION_URLCo-authored-by: Mathias Fredriksson <mafredri@gmail.com>
CODER_ADDRESS: "0.0.0.0:7080"
CODER_ACCESS_URL: "http://host.docker.internal:7080"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This can be set inside the specific template!

Override the "url" field of the "coder" provider!

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

TIL!

kylecarbs and bpmct reacted with eyes emoji
@Emyrk
Copy link
Member

I didn't realize we had a docker-compose. Sweet!

@johnstcnjohnstcnenabled auto-merge (squash)May 17, 2022 14:39
@johnstcnjohnstcn merged commit75dc8f5 intomainMay 17, 2022
@johnstcnjohnstcn deleted the cj/gh-1345/example-docker-host-gateway branchMay 17, 2022 14:40
@bpmct
Copy link
Member

Very smooth!

Not necessarily in this PR, but I think we still want to document the setup steps?

cd /path/to/coder/repodocker-compose up -dcoder login http://localhost:7080 # Create first usercoder templates create -d ./examples/docker-localcoder create dev

We could try to make some of them part of the compose file, perhaps it'd also be nicer todocker-compose run coder login ... to avoid having to install the binary.

@mafredri Yep, I'd like to document it, but I'd consider#1528 another blocker from this being a clean workflow.

I'm not really sure what the best way to document thecoder login thing is... 🤔

kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
* fix: example: update docker-local to use host-gateway* docker-compose.yaml: Add POSTGRES_ environment variables to CODER_PG_CONNECTION_URLCo-authored-by: Mathias Fredriksson <mafredri@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kylecarbskylecarbskylecarbs left review comments

@mafredrimafredrimafredri approved these changes

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@johnstcn@Emyrk@bpmct@mafredri@kylecarbs

[8]ページ先頭

©2009-2025 Movatter.jp