- Notifications
You must be signed in to change notification settings - Fork927
fix(coderd): improve workspace tests#15069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
stamp 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is there a follow-up PR to investigate re-enabling parallelism for these tests?
Just created the follow-up issue to keep it in mind. |
42e2a41 intomainUh oh!
There was an error while loading.Please reload this page.
I have fixed that by moving the workspace creation inside of each test 🤔#15077 |
Uh oh!
There was an error while loading.Please reload this page.
Witha recent PR we introducednew tests that - while running in parallel to the existing ones - are failing.
This PR is a quick proposal to fix it - tested in local and in the CI to unblock the situation. We can ignore it to work on a longer term solution if preferred.