Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(coderd/notifications): simplify TemplateWorkspaceManualBuildFailed#15067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SasSwart merged 5 commits intomainfromjjs/15065
Oct 15, 2024

Conversation

SasSwart
Copy link
Contributor

@SasSwartSasSwart commentedOct 14, 2024•
edited
Loading

This PRcloses#15065.

As advised by@mtojek, a template's display name may be set to "", which is not useful in an email notification. We'd like to provide a friendly name for the template, but it also needs to be identifiable.

As such, we fall back to template.Name in the case that the template's display name is empty.

Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM with nit.

Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fix LGTM 👍

I believe you can quickly fix it forTemplateTemplateDeleted too.

@SasSwartSasSwart marked this pull request as ready for reviewOctober 15, 2024 15:39
@SasSwartSasSwart merged commitfac77f9 intomainOct 15, 2024
29 checks passed
@SasSwartSasSwart deleted the jjs/15065 branchOctober 15, 2024 19:02
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 15, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mtojekmtojekmtojek left review comments

@dannykoppingdannykoppingdannykopping approved these changes

Assignees

@SasSwartSasSwart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TemplateWorkspaceManualBuildFailed renders an empty template display name
3 participants
@SasSwart@dannykopping@mtojek
[8]ページ先頭
©2009-2025 Movatter.jp