- Notifications
You must be signed in to change notification settings - Fork926
feat: allow promoting an existing template version to active from CLI#15051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
cli/templateversions.go Outdated
| ) | ||
| client := new(codersdk.Client) | ||
| cmd := &serpent.Command{ | ||
| Use: "promote", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't think there is precedence for required flags, can we add to theUse to include the required flags?
| Use:"promote", | |
| Use:"promote --template=<template_name> --template-version=<template_version_name>", |
We include required params in otherUse fields:
Line 18 in61c37d0
| Use:"autoupdate <workspace> <always|never>", |
| coder v0.0.0-devel | ||
| USAGE: | ||
| coder templates versions promote [flags] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I know the output[flags] technically includes my usage comment earlier. Given they are required, I wonder if we should include them more explicitly.
@Emyrk I've addressed the comments, please do have a look |
@Emyrk I think CI failure is unrelated, can we merge this? |
5ebc748 intocoder:mainUh oh!
There was an error while loading.Please reload this page.
It was, thanks@matifali 👍 |
Uh oh!
There was an error while loading.Please reload this page.
This PRcloses#15042