Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: usehashicorp/cloud-init provider in AWS devcontainer template#15050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
phorcys420 merged 4 commits intomainfromaws-devcontainer-cloudinit
Oct 27, 2024

Conversation

phorcys420
Copy link
Member

@phorcys420phorcys420 commentedOct 12, 2024•
edited
Loading

This PR makes templates uses thehashicorp/cloud-init provider instead of hardcoding a cloud-init config.
This makes for more readable/maintainable templates.

I tested this template on dev.coder.com and it works as expected.
seehttps://dev.coder.com/templates/coder/aws-devcontainer-cloudinit-test

Left to do:

  • Edit other templates that make use of cloud-init

cc:@johnstcn

matifali reacted with heart emoji
@phorcys420phorcys420 changed the titlefeaat: use hashicorp/cloud-init providein AWS templatesfeat: use hashicorp/cloud-init provider in AWS templatesOct 12, 2024
@phorcys420phorcys420 changed the titlefeat: use hashicorp/cloud-init provider in AWS templatesfeat: usehashicorp/cloud-initprovider in AWS templatesOct 12, 2024
@phorcys420phorcys420 changed the titlefeat: usehashicorp/cloud-initprovider in AWS templatesfeat: usehashicorp/cloud-init provider in AWS templatesOct 12, 2024
@phorcys420phorcys420 changed the titlefeat: usehashicorp/cloud-init provider in AWS templatesfeat: usehashicorp/cloud-init provider in AWS devcontainer templateOct 14, 2024
@phorcys420phorcys420 marked this pull request as ready for reviewOctober 14, 2024 12:36
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Tested it out and appears to work fine!

@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelOct 22, 2024
@github-actionsgithub-actionsbot removed the staleThis issue is like stale bread. labelOct 26, 2024
@matifali
Copy link
Member

@phorcys420, if it is ready, you can merge. Or are you planning to include other examples in the same PR?

@phorcys420
Copy link
MemberAuthor

hey@matifali -- I just need to remove a comment and rebase then it's good!

matifali reacted with rocket emoji

@phorcys420phorcys420force-pushed theaws-devcontainer-cloudinit branch from3e92337 toe080131CompareOctober 27, 2024 07:35
@phorcys420phorcys420enabled auto-merge (squash)October 27, 2024 13:14
@phorcys420phorcys420 merged commit91c337a intomainOct 27, 2024
23 checks passed
@phorcys420phorcys420 deleted the aws-devcontainer-cloudinit branchOctober 27, 2024 13:17
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 27, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@phorcys420phorcys420

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@phorcys420@matifali@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp