- Notifications
You must be signed in to change notification settings - Fork928
feat: allow for different docker socket path in docker-based templates (#15035)#15049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…ker-based templates (#15035)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This brings the template motion line with the kubernetes starter template 👍
How will it work for ssh docker hosts? Have you tested? |
79d24d2
intomainUh oh!
There was an error while loading.Please reload this page.
@matifali I have not tested it but when using SSH hosts you always have to either trust the host or disable host checking. seehttps://registry.terraform.io/providers/kreuzwerker/docker/latest/docs#remote-hosts |
Uh oh!
There was an error while loading.Please reload this page.
This PRfixes#15035, I have tested it on my instance and it works as expected.
I have opted to default to null, that way we don't have to hardcode our own default and we let the Docker provider default to whatever it wants.
This has the downside that it makes the template a little less readable, but it has the upside that we don't have to update the default if for some reason it ever changes.
We could also do something like this, but I like it less.
I have not edited the templates that are not present in examples/templates (namelyexamples/jfrog/docker andexamples/parameters), should I also edit these as well?
Maybe we would also want to move them to examples/templates in a separate PR?
NOTE: this PR does not cover using authenticated sources, so it's likely that only unix and tcp sockets would work out of the box but I think we don't want to include authenticated sockets OOTB (e.g SSH) because that would overcomplicate the template.
cc:@matifali