Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: use a smaller runner for e2e test#15034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
matifali merged 3 commits intomainfromatif/e2e-runner
Oct 12, 2024
Merged

Conversation

matifali
Copy link
Member

@matifalimatifali commentedOct 10, 2024•
edited
Loading

We run our e2e-tests on a 16-core machine with--max-workers=1
Using a standard runner with 2 cores, the machine runs the tests in the same amount of time while reducing the cost 8 times.

@matifalimatifali changed the titlechore: use a smaller runner fo e2e testchore: use a smaller runner for e2e testOct 10, 2024
@matifalimatifali marked this pull request as ready for reviewOctober 10, 2024 12:10
@matifali
Copy link
MemberAuthor

Ok. The e2e test is failing. Could it be because#14979 hasn't landed yet?

Copy link
Member

@mtojekmtojek left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

--max-workers=1
probably to reduce flakiness

Yes, at one point we had trouble running multiple tests in parallel because the machine was overloaded and started timing out. I think we could experiment to see if the situation has improved?

EDIT:

BTW if we want to increase parallelization level, we need to remember that this may affect API rate limit 👍

matifali reacted with thumbs up emoji
@matifali
Copy link
MemberAuthor

Thank you for the context@mtojek. We can investigate parallelism separately, my intention for this change now is to reduce CI compute cost.

Also could you or someone from the team have a look whytest-e2e is failing now whiletest-e2e-enterprise is passing.

@matifali
Copy link
MemberAuthor

Using a 4 core 16GB runner solves the issue. This is interesting for me and I would like to kno why.

@matifalimatifalienabled auto-merge (squash)October 12, 2024 11:20
@matifalimatifalienabled auto-merge (squash)October 12, 2024 11:21
@matifalimatifali merged commit20b3f8f intomainOct 12, 2024
29 checks passed
@matifalimatifali deleted the atif/e2e-runner branchOctober 12, 2024 11:23
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 12, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mtojekmtojekmtojek approved these changes

@ammarioammarioAwaiting requested review from ammario

Assignees

@matifalimatifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@matifali@mtojek
[8]ページ先頭
©2009-2025 Movatter.jp