- Notifications
You must be signed in to change notification settings - Fork926
chore(cli): rename build options to ephemeral parameters in cli#15030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…emeral-param' into chore/rename-build-option-to-ephemeral-param
| ephemeral parameters to model specific behaviors in a Coder workspace, such as | ||
| reverting to a previous image, restoring from a volume snapshot, or building a | ||
| project without using cache. | ||
| Ephemeral parameters are introduced to users in order to model specific behaviors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@EdwardAngert would you mind weighing in on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks, definitely up for some help here.
The main point@EdwardAngert is that I'd like to remove anything related to build_options. For the rest, really keen for some help but nothing has changed per itself in the logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Left a few suggestions, but otherwise looks good 👍
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
Thanks@mafredri - your suggestions improved the usage of it. Just waiting for some feedback in the documentation, but all good for me otherwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@defelmnq Looks like CI is complaining about some missing changes.
EdwardAngert commentedOct 14, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
incoming commit to try to fix some 404 errors and appease the CI |
Just fixed the CI here - logic and test side should be good - just waiting for a last review from@EdwardAngert as now the CI is happy and it will simplify changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, let's add a test to ensure the deprecated field still works.
Doesn't need to be exhaustive like the current tests, just one will suffice.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM! Thanks a lot@defelmnq
02f6203 intomainUh oh!
There was an error while loading.Please reload this page.
This PR aims to rename
build-optiontoephemeral-parametersbased on#10488 conversation.build-optionhas been renamedephemeral-parameterand can be used to define a value for an ephemeral parameter in the template.build-optionshas been renamedprompt-ephemeral-parametersand can be used to prompt the user to put values for the ephemeral parameters in the template.