- Notifications
You must be signed in to change notification settings - Fork928
fix(coderd): move test location to ignore Australia time saving error#15013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the hotfix, approved. And we definitely need to fix the underlying issue later.
6bf73a5 intomainUh oh!
There was an error while loading.Please reload this page.
| @@ -179,17 +179,17 @@ func Test_parseInsightsInterval_week(t *testing.T) { | |||
| t.Parallel() | |||
| layout := insightsTimeLayout | |||
| sydneyLoc, err := time.LoadLocation("Australia/Sydney") // Random location | |||
| losAngelesLoc, err := time.LoadLocation("America/Los_Angeles") // Random location | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
A test is currently failing because it relies on Sidney Tz.
from the internet :
Due to that - there's one hour missing in the tests - and the test
6 days are acceptableis failing.Changing to another timezone to fix the situation, it would require a longer-term solution or making sure it cannot happen anymore.