Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: provide example regexes to properly escape . characters#14983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

bcpeinhardt
Copy link
Contributor

Some of the example regular expressions we provide in the docs for managing coder external auth don't escape. characters correctly. This PR simply corrects that.

@bcpeinhardt
Copy link
ContributorAuthor

@matifali added you as a reviewer so you'll have the context for the zendesk ticket on Monday.

@bcpeinhardt
Copy link
ContributorAuthor

Do Not Merge until after docs restructure 🙏

@bcpeinhardtbcpeinhardt changed the titledocs: some example regexes to properly escape . charactersdocs: [Do Not Merge Yet] some example regexes to properly escape . charactersOct 4, 2024
@bcpeinhardtbcpeinhardt marked this pull request as draftOctober 4, 2024 18:24
@matifalimatifali changed the titledocs: [Do Not Merge Yet] some example regexes to properly escape . charactersdocs: some example regexes to properly escape . charactersOct 7, 2024
@matifalimatifali changed the titledocs: some example regexes to properly escape . charactersdocs: provide example regexes to properly escape . charactersOct 7, 2024
Copy link
Member

@matifalimatifali left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, Assuming you have already tested. Otherwise I will try to test later this week.

@bcpeinhardtbcpeinhardt marked this pull request as ready for reviewOctober 10, 2024 14:45
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelOct 22, 2024
@matifalimatifali removed the staleThis issue is like stale bread. labelOct 23, 2024
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelOct 31, 2024
@matifali
Copy link
Member

@bcpeinhardt do you still want to merge this?

@matifalimatifali reopened thisNov 3, 2024
@bcpeinhardt
Copy link
ContributorAuthor

Yes! It was failing CI before and I didn't have a chance to diagnose it.

@bcpeinhardtbcpeinhardt merged commit040e5cf intomainNov 3, 2024
49 checks passed
@bcpeinhardtbcpeinhardt deleted the bcpeinhardt/fix-some-example-regexes-to-escape-periods branchNovember 3, 2024 16:01
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsNov 3, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@matifalimatifalimatifali approved these changes

Assignees

@bcpeinhardtbcpeinhardt

Labels
staleThis issue is like stale bread.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@bcpeinhardt@matifali
[8]ページ先頭
©2009-2025 Movatter.jp