- Notifications
You must be signed in to change notification settings - Fork911
docs: provide example regexes to properly escape . characters#14983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
docs: provide example regexes to properly escape . characters#14983
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@matifali added you as a reviewer so you'll have the context for the zendesk ticket on Monday. |
Do Not Merge until after docs restructure 🙏 |
Uh oh!
There was an error while loading.Please reload this page.
matifali left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, Assuming you have already tested. Otherwise I will try to test later this week.
@bcpeinhardt do you still want to merge this? |
Yes! It was failing CI before and I didn't have a chance to diagnose it. |
040e5cf
intomainUh oh!
There was an error while loading.Please reload this page.
Some of the example regular expressions we provide in the docs for managing coder external auth don't escape
.
characters correctly. This PR simply corrects that.