Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: turn e2e enterprise tests into e2e premium tests#14979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 5 commits intomainfrome2e-premium
Oct 16, 2024

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedOct 4, 2024•
edited
Loading

  • Rename some e2e stuff from enterprise to premium
  • Shuffle secrets around for a premium license
  • Quit ignoring the results of the licensed e2e tests
  • Fix some tests that weren't passing

@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelOct 12, 2024
@matifalimatifali removed the staleThis issue is like stale bread. labelOct 12, 2024
@aslilacaslilac marked this pull request as ready for reviewOctober 16, 2024 17:19
// tweaking to make it work consistently (notably, ones that wait for agent
// stats on the workspace page. The default is like 50 seconds, which is
// way too long and makes it painful to wait for test runs in CI.
// actionTimeout: 5000, // 5 seconds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Would this be worth creating a separate issue to address this later?

Copy link
Contributor

@jaaydenhjaaydenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, just left a few questions.

@aslilacaslilac merged commit40fb57a intomainOct 16, 2024
29 checks passed
@aslilacaslilac deleted the e2e-premium branchOctober 16, 2024 22:54
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 16, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@jaaydenhjaaydenhjaaydenh approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@aslilac@jaaydenh@matifali
[8]ページ先頭
©2009-2025 Movatter.jp