- Notifications
You must be signed in to change notification settings - Fork928
feat(coderd/notifications): improve notification format consistency#14967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
20 commits Select commitHold shift + click to select a range
70f3486
feat(notifications): Improve notification format consistency
SasSwart7e31a34
chore(coderd/notifications): regenerate notification testdata from th…
SasSwartcf3afd4
Merge remote-tracking branch 'origin/main' into jjs/consistent-notifi…
SasSwart4b85f2b
chore(coderd/database): renumber migration
SasSwarte8ad3ac
chore(coderd/notifications): regenerate testdata
SasSwart2a4d740
fix(coderd/notifications): remove duplicate function signature
SasSwarte741c43
chore: remove redundant escaping in migration
SasSwartadffe60
chore(coderd/notifications): improve failed test feedback
SasSwart41ed54a
feat(coderd/database): add new information to the account activated n…
SasSwart5541331
Merge remote-tracking branch 'origin/main' into jjs/additional-notifi…
SasSwartfe94f0d
chore(coderd/database): rework migration for legibility
SasSwart98e7501
feat(coderd): send newly required information to notification templates
SasSwartd8e00c2
feat(coderd/notifications): provide additional context to workspace n…
SasSwartd6a339f
fix(coderd/notifications): add a missing call to fmt.Sprintf
SasSwart920ad31
fix(coderd/notifications): fix oversights in template migration
SasSwart9e938e5
chore(coderd/provisionerdserver): set the displayname in TestNotifica…
SasSwart59e57ac
chore(coderd): add more robust testing assertions to TestNotifyDelete…
SasSwartc907238
chore(coderd/notifications): fix migration indentation
SasSwart2493556
chore(coderd/notifications): regenerate golden files
SasSwart19dccc8
Merge remote-tracking branch 'origin/main' into jjs/consistent-notifi…
SasSwartFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
fix(coderd/notifications): remove duplicate function signature
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit2a4d740fde9c3ff1e9ce4948c96fda4112d901f0
There are no files selected for viewing
1 change: 0 additions & 1 deletioncoderd/notifications/notifications_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.