All contributors have signed the CLA ✍️ ✅
_{Posted by theCLA Assistant Lite bot.}

I have read the CLA Document and I hereby sign the CLA

I think you need to regenerate the text samples withmake update-golden-files, or overwrite default forupdateGoldenFiles (false -> true) and rerun test.

We should make the test output this hint on error (i.e. change requires to assert and if test failed, show hint). Right now it's only shown when there are missing files.

I think you need to regenerate the text samples with make update-golden-files, or overwrite default for updateGoldenFiles (false -> true) and rerun test.

I was trying to do this for most of Friday. Turns out that the makefile wasn't actually calling the right test to update these. Firstly because it didn't have a job in the makefile for the notifications package, but also because the test wasn't named correctly.

I've pushed a commit that fixes it. We now have updated testdata, which has shown some issues. I'm working on resolving them. Expect updated queries and rendered testdata soon.

@mtojek@mafredri

Apologies, but I wasn't happy with the standard of the PR. I reworked it after considering some verbal feedback (thanks@mafredri and@defelmnq).

I also figured out how to deal with the rest of#14893.

Please have another look?

Enough has changed that I would have revoked the initial approvals if I could.
I'd particularly appreciate your thoughts on my changes in functions postUser, postFirstUser and oauthLogin

Re#14967 (comment):

I wondered about this, but didn't want to assume I could overwrite what was specified.
Will update.

@SasSwart@dannykopping Right now the result looks strange. Please take a look below at the notification I received today, it needs more love. I still don't think we need to refer to thedisplay name specifically.