- Notifications
You must be signed in to change notification settings - Fork927
fix: Allow fetching of non-personal workspaces#1495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
RBAC should cover this anyways!
| @@ -92,31 +92,6 @@ func TestWorkspaceParam(t *testing.T) { | |||
| require.Equal(t, http.StatusNotFound, res.StatusCode) | |||
| }) | |||
| t.Run("NonPersonal", func(t *testing.T) { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do we have any tests for the workspace RBAC already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think all of these endpoints need a thorough comb-over already, so the answer is no, but that's also the status quo.
RBAC should cover this anyways!
RBAC should cover this anyways!