- Notifications
You must be signed in to change notification settings - Fork928
feat: expose Markdown fields in webhook payload#14931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -28,17 +28,15 @@ func TestWebhook(t *testing.T) { | |||
| t.Parallel() | |||
| const ( | |||
| titleTemplate = "this is the title ({{.Labels.foo}})" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
for reviewer:
Dispatch can't render Go templates, it expects already rendered arguments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
0aa84b1 intomainUh oh!
There was an error while loading.Please reload this page.
@EdwardAngert, we need to take these docs changes into |
Fixes:#14930
Integrations with webhook handlers can render Markdown accordingly to their formatting rules. This PR adds the original (with Markdown) body and title fields to payloads.