Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: remove dark blue theme#14890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 2 commits intocoder:mainfromzxt-tzx:feat/rm-dark-blue
Oct 2, 2024
Merged

Conversation

zxt-tzx
Copy link
Contributor

@zxt-tzxzxt-tzx commentedOct 1, 2024•
edited
Loading

saw this issue#14811, looks like an easy change

considered trying to modify the type exported fromUpdateUserAppearanceSettingsRequest intypesGenerated.ts to be"light" | "dark", but not super sure how to generate types from the Go codebase, so have left this as it is

@cdr-botcdr-botbot added the communityPull Requests and issues created by the community. labelOct 1, 2024
@github-actionsGitHub Actions
Copy link

github-actionsbot commentedOct 1, 2024•
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by theCLA Assistant Lite bot.

@zxt-tzx
Copy link
ContributorAuthor

I have read the CLA Document and I hereby sign the CLA

cdrcommunity added a commit to coder/cla that referenced this pull requestOct 1, 2024
@zxt-tzx
Copy link
ContributorAuthor

thetest-e2e test failed, can't tell if it's just a flaky test or something with the changes I've made

[stderr] [WebServer] 2024-10-01 13:26:12.993 [info]  coderd.agentrpc.yamux.stdlib: [ERR] yamux: Failed to read header: failed to get reader: failed to read frame header: EOF  owner=admin  workspace_name=43111e0b  agent_name=dev  request_id=108bea26-2d26-46a3-9a22-c675f4e09fa4

@aslilac
Copy link
Member

aslilac commentedOct 1, 2024•
edited
Loading

pardon our messy e2e test output. that line you're looking at is unrelated, the real error was:

==> Finished test external auth device: failed

with no extra details. 🙃 I'm assuming it's a flake and just started a re-run. I'll be back in a bit to check on it and give you a review.

Copy link
Member

@aslilacaslilac left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

we'll also want to add a db migration that sets the theme of any users currently using the dark blue theme back to the default, otherwise they won't see anything selected on the appearance settings page.

it should just look like:

UPDATE usersSET theme_preference=''WHERE theme_preference='darkBlue';

and the down migration can just be an empty file with a comment saying something like

-- Nothing to restore

You can create the migration files by running...

./coderd/database/migrations/create_migration.sh remove-dark-blue-theme

Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

looks great! thank you!

@aslilacaslilac merged commitd0a8424 intocoder:mainOct 2, 2024
29 checks passed
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 2, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac approved these changes

@chrifrochrifroAwaiting requested review from chrifro

Assignees

@zxt-tzxzxt-tzx

Labels
communityPull Requests and issues created by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@zxt-tzx@aslilac
[8]ページ先頭
©2009-2025 Movatter.jp