- Notifications
You must be signed in to change notification settings - Fork1.1k
fix: remove redundant flaking test#14888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
MemberAuthor
ethanndickson commentedOct 1, 2024
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@ethanndickson and the rest of your teammates on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This PR is a hotfix and has been automatically approved.
- ✅ Base is main or release branch
- ✅ Has hotfix label
- ✅ Head is from coder/coder
- ✅ Less than 100 lines
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Closes#14877.
I suspect this was flaking on CI as the
dbtimeused for the refreshed expiry was being rounded to the nearest microsecond. The time values we're comparing are always super close together. and I assume they were being compared as equal? I noticed the flakes were only occurring when the whole test was running in under 100ms, and I was unable to get the tests to fail locally, nor could I get the test to run that quickly. (It also might have been a Windows time precision issue? I only saw the flake on Windows)Regardless, we already have a test for this in
httpmw/apikey_test.go, and when I wrote this variation it was mainly just to sanity check cli tokens were getting refreshed at all - I now know all apikeys get refreshed!I don't think we need to test it again at the
coderdlevel, so I'm happy to get rid of it.