Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: show user-auth provisioners#14883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
f0ssel merged 9 commits intomainfromf0ssel/user-auth-provisioners
Oct 1, 2024
Merged

Conversation

f0ssel
Copy link
Contributor

@f0sself0ssel commentedSep 30, 2024•
edited
Loading

Closes#14867

What this changes:

  • Displaysuser-auth grouped provisioners
  • Added tags to provisioners in cases where it matters
image

@f0sself0ssel marked this pull request as ready for reviewSeptember 30, 2024 19:22
@aslilac
Copy link
Member

why'd you remove the inline group tags? those were part of the design, and we never talked about removing them

Emyrk reacted with eyes emoji

Co-authored-by: Ben Potter <ben@coder.com>
Comment on lines 150 to 154
// Currently the user-auth key orgID is hardcoded to the default org.
// This will be changed when we update the `user-auth` keys to be
// directly tied to a user ID.
ifkey.ID.String()==codersdk.ProvisionerKeyIDUserAuth {
continue
key.OrganizationID=organization.ID
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This says the default org, but theorganization could be any org right? Theorganization.ID comes from the org in the url

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Comment is confusing and will update it. Theuser-authkey.OrganizationID is hardcoded to thedefault org in the database and we are overwriting it here. Theorganization is valid here because it's the ID we use to query the list to begin with. It's just that for provisioners in the non-default org that useuser-auth would have the default org ID returned here, so we edit the fakeuser-auth key to have the correct org here before returning it.

Emyrk reacted with thumbs up emoji
@f0ssel
Copy link
ContributorAuthor

f0ssel commentedOct 1, 2024•
edited
Loading

@aslilac tags patch lgtm,would you mind updating the screenshot of the page nvm I got it. Feel free to approve whenever you are ready, thanks

@f0sself0ssel merged commit533d655 intomainOct 1, 2024
35 checks passed
@f0sself0ssel deleted the f0ssel/user-auth-provisioners branchOctober 1, 2024 17:12
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 1, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@bpmctbpmctbpmct left review comments

@aslilacaslilacaslilac approved these changes

@EmyrkEmyrkEmyrk approved these changes

Assignees

@f0sself0ssel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Provisioners started by user account do not show up in provisioners UI

4 participants

@f0ssel@aslilac@Emyrk@bpmct
[8]ページ先頭
©2009-2025 Movatter.jp