Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: sort provisioner key tags in cli output#14875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/flake-provisioner-keys-tags
Oct 1, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedSep 30, 2024•
edited
Loading

I'm seeing flakes like

    provisionerkeys_test.go:68: 2024-09-30 05:58:44.686: cmd: matched newline = "CREATED AT            NAME          TAGS            "    provisionerkeys_test.go:72: 2024-09-30 05:58:44.686: cmd: matched newline = "2024-09-30T05:58:44Z  dont-test-me  my=way foo=bar  "    provisionerkeys_test.go:74:         Error Trace:/Users/runner/work/coder/coder/enterprise/cli/provisionerkeys_test.go:74        Error:      "2024-09-30T05:58:44Z  dont-test-me  my=way foo=bar  " does not contain "foo=bar my=way"        Test:       TestProvisionerKeys/CRUD

e.g.https://github.com/coder/coder/actions/runs/11100237276/job/30835714478?pr=14855

Since the tags are a map, we weren't outputting them in a consistent order on the CLI, leading to flakes.

This sorts the tags by key when converting to a string, for a consistent, canonical output.

ethanndickson reacted with heart emoji
@spikecurtisGraphite App
Copy link
ContributorAuthor

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@spikecurtis and the rest of your teammates onGraphiteGraphite

@spikecurtisspikecurtis marked this pull request as ready for reviewSeptember 30, 2024 12:57
@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedOct 1, 2024•
edited
Loading

Merge activity

@spikecurtisspikecurtis merged commitd6766f7 intomainOct 1, 2024
34 checks passed
@spikecurtisspikecurtis deleted the spike/flake-provisioner-keys-tags branchOctober 1, 2024 05:11
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 1, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@f0sself0sselAwaiting requested review from f0ssel

@deansheatherdeansheatherAwaiting requested review from deansheather

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@spikecurtis@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp