- Notifications
You must be signed in to change notification settings - Fork925
chore: addsite flag tobuildinfo#14868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@ethanndickson and the rest of your teammates on |
site flag tobuildinfo
dannykopping left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, thanks for addressing this.
Side-note:coder/internal#54 (which you addressed in the previous PR) says to only open the browser on thefirst run. This happens on every run currently, and I think we ought to mention how to disable this.
Perhaps like this?
╔═══════════════════════════════════════════════╗║ View the Web UI: ║║ https://et23ntkhpueak.pit-1.try.coder.app ║║ Disable auto-open with `--no-open` ║╚═══════════════════════════════════════════════╝Or only do so when the first user has not been created?
The database doesn't get initialised until a fair bit after we print the access URL, after which a bunch of logs will have streamed in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, thanks 👍
03ac0f8 to7fa8132Compare7fa8132 to9075bf9Compare35a5475 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
As of#14761, the access URL is automatically opened in the browser when running
coder server. This becomes annoying when running versions of Coder without a frontend during development.This PR skips opening the URL in the browser when there is no frontend embedded into the binary. Since this is different from a
slimbuild of Coder (i.e. a true slim build is ~40mb, this build is ~120mb), it wouldn't make sense to set the existingslimflag to true. The solution is to add a newsiteflag, and ahasSitefunction tobuildinfothat can be used to detect frontendless builds.