Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add CoderVPN protocol definition & implementation#14855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/codervpn-protobuf
Oct 1, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedSep 27, 2024•
edited
Loading

closes#14731

Defines and implements the CoderVPN control protocol, which will be used to communicate with desktop client applications.

@spikecurtisGraphite App
Copy link
ContributorAuthor

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@spikecurtis and the rest of your teammates onGraphiteGraphite

@spikecurtisspikecurtis marked this pull request as ready for reviewSeptember 27, 2024 11:35
"cdr.dev/slog"
)

type Tunnel struct {
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Note to reviewers:

This component is not finished and not unit tested. I built the basic skeleton of it to inform how the API for thespeaker should look, and as an illustrative example for reviewers of how thespeaker will be used in practice.

It will be completed and tested after we have the other pieces in place to actually start the CoderVPN tunnel using thetailnet package.

sreya reacted with thumbs up emoji
Copy link
Collaborator

@sreyasreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good overall, I like the extensive comments. Some potential suggestions related to naming.

case s.recvCh <- msg:
s.logger.Debug(s.ctx, "passed received message to speaker")
case <-s.ctx.Done():
s.logger.Debug(s.ctx, "recvLoop canceled", slog.Error(s.ctx.Err()))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could probably omit thectx.Err() here

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'll admit it's almost always "context canceled" but sometimes it's "deadline exceeded" and that's interesting and occasionally useful in debugging, which is whatDebug messages are supposed to be for.

@spikecurtisspikecurtis changed the titlefeat: add CoderVPN protocol definition & implementaionfeat: add CoderVPN protocol definition & implementationSep 30, 2024
@spikecurtisspikecurtis merged commitf7ddbb7 intomainOct 1, 2024
30 checks passed
@spikecurtisspikecurtis deleted the spike/codervpn-protobuf branchOctober 1, 2024 15:40
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 1, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@sreyasreyasreya approved these changes

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for CoderVPN Control Protocol
2 participants
@spikecurtis@sreya
[8]ページ先頭
©2009-2025 Movatter.jp