Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(helm): add setting to disable service account creation#14817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ericpaulsen merged 5 commits intocoder:mainfromMaxTNielsen:patch-1
Oct 23, 2024
Merged

feat(helm): add setting to disable service account creation#14817

ericpaulsen merged 5 commits intocoder:mainfromMaxTNielsen:patch-1
Oct 23, 2024

Conversation

@MaxTNielsen
Copy link
Contributor

Add a setting to disable service account creation

Add a setting to disable service account creation
@cdr-botcdr-botbot added the communityPull Requests and issues created by the community. labelSep 26, 2024
@github-actions
Copy link

github-actionsbot commentedSep 26, 2024•
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by theCLA Assistant Lite bot.

@MaxTNielsenMaxTNielsen changed the titleUpdate coder.yamlfeat(helm): use existing svcSep 26, 2024
@MaxTNielsen
Copy link
ContributorAuthor

I have read the CLA Document and I hereby sign the CLA

cdrcommunity added a commit to coder/cla that referenced this pull requestSep 26, 2024
@MaxTNielsenMaxTNielsen changed the titlefeat(helm): use existing svcfeat(helm): add setting to disable service account creationSep 26, 2024
Changed to disableCreate
Changed to disableCreate
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelOct 11, 2024
@matifalimatifali removed the staleThis issue is like stale bread. labelOct 12, 2024
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelOct 20, 2024
@matifalimatifali removed the staleThis issue is like stale bread. labelOct 23, 2024
@ericpaulsenericpaulsen merged commitcd92220 intocoder:mainOct 23, 2024
24 checks passed
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 23, 2024
@johnstcn
Copy link
Member

@ericpaulsen Let's make sure there's a corresponding test case for the Helm chart!

@sreya
Copy link
Collaborator

Doesn't this change our default behavior?

@johnstcn
Copy link
Member

@sreya see#15197, I want to keep the same default behaviour

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@kylecarbskylecarbskylecarbs left review comments

@ericpaulsenericpaulsenericpaulsen approved these changes

Assignees

@MaxTNielsenMaxTNielsen

Labels

communityPull Requests and issues created by the community.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@MaxTNielsen@johnstcn@sreya@kylecarbs@ericpaulsen@matifali
[8]ページ先頭
©2009-2025 Movatter.jp