Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat!: add summary tocoder ping#14762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 4 commits intomainfrom09-23-feat_add_summary_to_coder_ping_
Sep 25, 2024

Conversation

@ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedSep 23, 2024•
edited
Loading

Closes#14752.

This is a breaking change, as the default behavior ofcoder ping is now to ping indefinitely, until an interrupt is detected (alike many other ping commands, e.g.iputils ping). Previously,coder ping performed 10 pings by default. The-n argument can still be used to perform a fixed number of pings.

All diagnostics are also now written tostderr, instead ofstdout.

New format with diagnostics included:

$ coder ping dev✔ preferred DERP region: 10015 (Australia Fly.io (Sydney))✔ sent local data to Coder networking coordinator✔ received remote agent data from Coder networking coordinator    preferred DERP region: 999 (Council Bluffs, Iowa)    endpoints: xxx.xx.xxx.xxx:13337, xxx.xx.x.x:13337, xxx.xx.x.x:13337✔ Wireguard handshake 0s ago❗ The DERP map is not configured to use STUN   https://coder.com/docs/@v2.15.0/networking/troubleshooting#no-stun-serversPossible client-side issues with direct connection: - Client IP address is within an AWS range (AWS uses hard NAT)   https://coder.com/docs/@v2.15.0/networking/troubleshooting#endpoint-dependent-nat-hard-natPossible agent-side issues with direct connections: - Agent IP address is within an AWS range (AWS uses hard NAT)   https://coder.com/docs/@v2.15.0/networking/troubleshooting#endpoint-dependent-nat-hard-natpong from dev proxied via DERP(Council Bluffs, Iowa) in 209mspong from dev proxied via DERP(Council Bluffs, Iowa) in 209mspong from dev proxied via DERP(Council Bluffs, Iowa) in 208mspong from dev proxied via DERP(Council Bluffs, Iowa) in 209mspong from dev proxied via DERP(Council Bluffs, Iowa) in 209ms<SIGINT>❗ You are connected via a DERP relay, not directly (p2p)https://coder.com/docs/@v2.15.0/networking/troubleshooting#common-problems-with-direct-connections--------------------------------------------------------------------------------WORKSPACE  TOTAL  SUCCESSFUL  MIN           AVG          MAX           STDDEV    dev            5           5  208.407931ms  208.49958ms  208.544751ms  47.328µs

(These links will be broken until the next release, as the troubleshooting page wasn't included inv2.15.0)

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@ethanndickson and the rest of your teammates onGraphiteGraphite

@ethanndicksonethanndicksonforce-pushed the09-23-feat_add_summary_to_coder_ping_ branch 5 times, most recently from6fefb45 to02d2b5aCompareSeptember 24, 2024 05:49
@ethanndicksonethanndickson marked this pull request as ready for reviewSeptember 24, 2024 05:53
Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I didn't read the diagnostics in your post but I think all diagnostics need to go at the end rather than some first and some afterwards.

ethanndickson reacted with thumbs up emoji
@ethanndicksonethanndicksonforce-pushed the09-23-feat_add_summary_to_coder_ping_ branch 2 times, most recently fromc7a014b tod696befCompareSeptember 24, 2024 12:53
@ethanndicksonethanndicksonforce-pushed the09-23-feat_add_summary_to_coder_ping_ branch fromd696bef tod1040d5CompareSeptember 24, 2024 13:20
Comment on lines +67 to +71
ifs.Successful>0 {
s.Avg=ptr.Ref(time.Duration(s.latencySum/float64(s.Successful)*float64(time.Second)))
}
ifs.Successful>1 {
s.Variance=ptr.Ref(time.Duration((s.m2/float64(s.Successful-1))*float64(time.Second)))
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This can be calculated on every addResult call no?

@deansheather
Copy link
Member

Wait, in your updated description you're dumping whether it's ping/p2p first? You can't log that until after you've finished pinging

@ethanndickson
Copy link
MemberAuthor

ethanndickson commentedSep 24, 2024•
edited
Loading

❗ You are connected via a DERP relay, not directly (p2p)https://coder.com/docs/@v2.15.0/networking/troubleshooting#common-problems-with-direct-connections

Was the only diagnostic left at the end when you said:

I didn't read the diagnostics in your post but I think all diagnostics need to go at the end rather than some first and some afterwards.

So I moved it up!

We're doing the silent ping ammar suggested to determine whether or not we'll show diagnostics at all, which is what I used to print it - but I'm definitely in favour of keeping it at the end.

@ethanndicksonethanndicksonforce-pushed the09-23-feat_add_summary_to_coder_ping_ branch fromd1040d5 to0efd6edCompareSeptember 24, 2024 14:47
@ethanndicksonethanndickson merged commitb7c574f intomainSep 25, 2024
@ethanndicksonethanndickson deleted the 09-23-feat_add_summary_to_coder_ping_ branchSeptember 25, 2024 03:24
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 25, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@ammarioammarioammario approved these changes

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@ethanndicksonethanndickson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

coder ping UX concerns

4 participants

@ethanndickson@deansheather@ammario
[8]ページ先頭
©2009-2025 Movatter.jp