Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: improvecoder server ux#14761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 1 commit intomainfrom09-23-chore_improve_coder_server_ux
Sep 24, 2024

Conversation

@ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedSep 23, 2024•
edited
Loading

Closescoder/internal#54.

Currently,coder server doesn't take any steps to ensure the access URL it outputs stands out among the initial stream of logs.
To address this, this PR:

  • Wraps the access URL in a colourful box (ANSI bright blue (12) box, ANSI magenta (5) hyperlink)
    image

  • Opens the access URL in the default browser, if theBROWSER env var is set, and if outputting to a TTY. Can be disabled using--no-open. This is the same behaviour ascoder login.

  • Improves the naming of some loggers, as some logs were previously duplicated with no indication as to why.

  • Changes some startup logs frominfo todebug

The full startup output is now:

$ coder serverCoder v2.15.0-devel+0dc2a89b9 - Your Self-Hosted Remote Development PlatformStarted HTTP listener at http://127.0.0.1:3000Using built-in PostgreSQL (/home/coder/.config/coderv2/postgres)╔═════════════════════════════╗║      View the Web UI:       ║║   https://www.example.com   ║╚═════════════════════════════╝==> Logs will stream in below (press ctrl+c to gracefully exit):2024-09-23 13:46:54.105 [info]  provisionerd-dev-0: successfully connected to coderd2024-09-23 13:46:54.105 [info]  provisionerd-dev-1: successfully connected to coderd2024-09-23 13:46:54.107 [info]  provisionerd-dev-2: successfully connected to coderd2024-09-23 13:46:54.128 [info]  provisionerd-dev-2: detected terraform version  installed_version=1.9.2  min_version=1.1.0  max_version=1.9.92024-09-23 13:46:54.128 [info]  provisionerd-dev-0: detected terraform version  installed_version=1.9.2  min_version=1.1.0  max_version=1.9.92024-09-23 13:46:54.129 [info]  provisionerd-dev-1: detected terraform version  installed_version=1.9.2  min_version=1.1.0  max_version=1.9.9

I'd argue the remaininginfo level logs are appropriate, I think something like how many provisioners are running, and what terraform version they're running are worth outputting by default, but very much open to thoughts.

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@ethanndickson and the rest of your teammates onGraphiteGraphite

@ethanndicksonethanndicksonforce-pushed the09-23-chore_improve_coder_server_ux branch frombf8650d to0dc2a89CompareSeptember 23, 2024 05:36
@ethanndicksonethanndickson marked this pull request as ready for reviewSeptember 23, 2024 05:42
@ethanndicksonethanndicksonforce-pushed the09-23-chore_improve_coder_server_ux branch from0dc2a89 toc628077CompareSeptember 23, 2024 13:50
@ammario
Copy link
Member

Looks clean. Thank you.

@ethanndicksonethanndickson merged commitb894407 intomainSep 24, 2024
@ethanndicksonethanndickson deleted the 09-23-chore_improve_coder_server_ux branchSeptember 24, 2024 03:16
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 24, 2024
@dannykopping
Copy link
Contributor

@ethanndickson heads up: this seems to open the access URL even if it's a slim build (and therefore has no UI bundled).

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@sreyasreyasreya approved these changes

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@ethanndicksonethanndickson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate preventing log spam from burying access URL on initial setup

6 participants

@ethanndickson@ammario@dannykopping@sreya@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp