Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add 'display_name' column to 'workspace_agent_scripts'#14747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
DanielleMaywood merged 3 commits intomainfromdm-add-display-name-to-script-table
Sep 20, 2024

Conversation

DanielleMaywood
Copy link
Contributor

@DanielleMaywoodDanielleMaywood commentedSep 20, 2024•
edited
Loading

Add adisplay_name column toworkspace_agent_scripts table.

display_name is sourced fromcoder_script resource inthe coder terraform provider. It will be used in the UI when we display script timings.

Work on#14713 requiresdisplay_name to be present in the database.

@DanielleMaywoodDanielleMaywood marked this pull request as ready for reviewSeptember 20, 2024 12:45
Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Would you mind adding some more detail to the description about where this value comes from, and how it will be used?

@DanielleMaywood
Copy link
ContributorAuthor

Would you mind adding some more detail to the description about where this value comes from, and how it will be used?

Done! Let me know if you want more detail.

@dannykopping
Copy link
Contributor

Perfect, thanks 👍

@dannykopping
Copy link
Contributor

@DanielleMaywood should we wait for the other PR to be merged first?

@DanielleMaywood
Copy link
ContributorAuthor

I think this PR should go first as this is to pull out thedisplay_name change from that one into a separate PR.

Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@DanielleMaywoodDanielleMaywood merged commit86f68b2 intomainSep 20, 2024
39 checks passed
@DanielleMaywoodDanielleMaywood deleted the dm-add-display-name-to-script-table branchSeptember 20, 2024 13:26
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 20, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@dannykoppingdannykoppingdannykopping approved these changes

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@DanielleMaywoodDanielleMaywood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@DanielleMaywood@dannykopping@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp