Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: reorganize and edit docs README#14706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
EdwardAngert merged 5 commits intomainfromea-rewrite-readme
Oct 14, 2024
Merged

Conversation

EdwardAngert
Copy link
Contributor

Edit the docs readme for consistency and better flow

stirby and matifali reacted with thumbs up emoji
@EdwardAngertEdwardAngert added the docsArea: coder.com/docs labelSep 17, 2024
@EdwardAngertEdwardAngert self-assigned thisSep 17, 2024
@github-actionsGitHub Actions
Copy link

github-actionsbot commentedSep 17, 2024
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by theCLA Assistant Lite bot.

Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, except a few comments. I don't need to review again.

@EdwardAngert
Copy link
ContributorAuthor

I have read the CLA Document and I hereby sign the CLA

cdrcommunity added a commit to coder/cla that referenced this pull requestSep 18, 2024
@stirby
Copy link
Collaborator

In the coder/coder repo on your machine, runmake fmt to satisfy CI.

@EdwardAngert
Copy link
ContributorAuthor

EdwardAngert commentedSep 18, 2024
edited
Loading

thanks@stirby - I had a series of errors when I ranmake fmt, even after installing all the dependencies and adding things toPATH (well,~/.zprofile):

full error text
❯ make fmt                                                                                                                                                                          ─╯ERROR: You need GNU getopt to run the scriptsin the Coder repo.On darwin:- brew install gnu-getopt- Add"$(brew --prefix gnu-getopt)/bin" to your PATH- Restart your terminalERROR: You need at least make 4.0 to run the scriptsin the Coder repo.On darwin:- brew install make- Add"$(brew --prefix make)/libexec/gnubin" to your PATH- Restart your terminalERROR: Invalid dependencies, see abovefor more details.==> fmt/ts ERR_PNPM_NO_SCRIPT  Missing script: check:fixCommand"check:fix" not found.make:*** [fmt/ts] Error 1

once I figured out it's just running prettier, I used npx instead and that seemed to do the trick:npx prettier -c docs/README.md (-c to check, then-w to write)

matifali reacted with thumbs up emoji

@matifali
Copy link
Member

matifali commentedSep 19, 2024
edited
Loading

@EdwardAngert Edward You can also create a workspace from thedogfood template and runmake fmt on your PR branch.
you can do it in 2 steps

  1. gh pr checkout 14706
  2. make fmt
EdwardAngert reacted with heart emoji

@EdwardAngertEdwardAngertforce-pushed theea-rewrite-readme branch 5 times, most recently from0f6085a to66d75f8CompareSeptember 27, 2024 20:05
Base automatically changed fromrestructure-new tomainOctober 5, 2024 15:52
@matifali
Copy link
Member

I think it would be easy if you could redo this PR@EdwardAngert.

cc:@stirby

@EdwardAngert
Copy link
ContributorAuthor

@matifali rebasing seemed messy and complicated, so I reset the branch to matchmain and copied the changes over to the doc - I didn't rename it toindex.md though, since the live version is stillREADME.md (link). Should I rename it anyway and pointmanifest.json to it?

Co-authored-by: Muhammad Atif Ali <atif@coder.com>
@EdwardAngertEdwardAngert merged commit88c6a75 intomainOct 14, 2024
24 checks passed
@EdwardAngertEdwardAngert deleted the ea-rewrite-readme branchOctober 14, 2024 17:39
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 14, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@matifalimatifalimatifali approved these changes

@stirbystirbyAwaiting requested review from stirby

Assignees

@EdwardAngertEdwardAngert

Labels
docsArea: coder.com/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@EdwardAngert@stirby@matifali

[8]ページ先頭

©2009-2025 Movatter.jp