- Notifications
You must be signed in to change notification settings - Fork928
fix(coderd): check if timings can be read#14697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| @@ -1792,6 +1792,10 @@ func (q *querier) GetProvisionerJobByID(ctx context.Context, id uuid.UUID) (data | |||
| } | |||
| func (q *querier) GetProvisionerJobTimingsByJobID(ctx context.Context, jobID uuid.UUID) ([]database.ProvisionerJobTiming, error) { | |||
| _, err := q.GetProvisionerJobByID(ctx, jobID) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This approach raised my eyebrow, and I was going to suggest not doing it this way but I see we have precedent for this inGetProvisionerJobByID itself. Please add a comment explaining this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm sure we use a similar pattern for workspace builds or templates.
LOL, but in my defense, the title is pretty descriptive and it is just 5 lines of code change |
370f0b9 intomainUh oh!
There was an error while loading.Please reload this page.
No description provided.