NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

chore: use legacy "AssignDefault" option for legacy behavior in SCIM#14696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Emyrk merged 2 commits intocolin/scim-orgfromstevenmasley/scim_adjust

Sep 17, 2024

Merged

chore: use legacy "AssignDefault" option for legacy behavior in SCIM#14696

Emyrk merged 2 commits intocolin/scim-orgfromstevenmasley/scim_adjust

Sep 17, 2024

Conversation

Copy link

Member

Emyrk commentedSep 16, 2024

AssignDefault is a boolean flag mainly for single org and legacy deployments. Use this flag to determine SCIM behavior.

Mimics behavior of OIDC auth creating a user:

coder/coderd/userauth.go

Lines 1312 to 1315 inb03cb00

	orgIDs:= []uuid.UUID{}
	ifparams.OrganizationSync.IncludeDefault {
	orgIDs=append(orgIDs,defaultOrganization.ID)
	}

In future we should probably reuse the same code path for OIDC and SCIM auth flow.

chore: reference legacy assign default option for legacy behavior

b03cb00

AssignDefault is a boolean flag mainly for single org and legacydeployments. Use this flag to determine SCIM behavior.

github-actionsbot assignedEmyrk

Sep 16, 2024

linting

cdfb475

Emyrk changed the title~~chore: reference legacy assign default option for legacy behavior~~chore: user legacy "AssignDefault" option for legacy behavior in SCIM

Sep 16, 2024

Emyrk changed the title~~chore: user legacy "AssignDefault" option for legacy behavior in SCIM~~chore: use legacy "AssignDefault" option for legacy behavior in SCIM

Sep 16, 2024

Emyrk requested a review fromcoadler

September 16, 2024 21:34