Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add test for coord rolling restart#14680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 2 commits intomainfromdean/coord-rolling-restart-test
Nov 20, 2024

Conversation

deansheather
Copy link
Member

@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelOct 1, 2024
@sreyasreya reopened thisOct 14, 2024
@github-actionsgithub-actionsbot removed the staleThis issue is like stale bread. labelOct 15, 2024
@ethanndicksonethanndicksonforce-pushed thedean/coord-rolling-restart-test branch froma8c5708 to75849b8CompareOctober 18, 2024 06:43
@ethanndicksonethanndickson marked this pull request as ready for reviewOctober 18, 2024 06:53
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelNov 13, 2024
@sreyasreya reopened thisNov 18, 2024
@github-actionsgithub-actionsbot removed the staleThis issue is like stale bread. labelNov 19, 2024
@ethanndicksonethanndicksonforce-pushed thedean/coord-rolling-restart-test branch from84a6d82 toe454e42CompareNovember 19, 2024 01:46
@ethanndickson
Copy link
Member

After a rebase on main, the test is now failing due to the dialer creating an error log while the server is down:

    t.go:115: 2024-11-19 01:50:26.405 [erro]  client: failed to dial tailnet v2+ API  error="failed to WebSocket dial: expected handshake response status code 101 but got 502" ...        sdk_err= GET http://127.0.0.1:46789/api/v2/workspaceagents/54909b8e-b909-46fa-a33d-33afa7780731/coordinate?resume_token=*** unexpected status code 502: unexpected non-JSON response "text/plain; charset=utf-8"                 Error: server is not started         *** slogtest: log detected at level ERROR; TEST FAILURE ***    t.go:115: 2024-11-19 01:50:26.405 [erro]  client: failed to dial tailnet v2+ API  error="failed to WebSocket dial: expected handshake response status code 101 but got 502"         *** slogtest: log detected at level ERROR; TEST FAILURE ***

@spikecurtis
Copy link
Contributor

After a rebase on main, the test is now failing due to the dialer creating an error log while the server is down:

    t.go:115: 2024-11-19 01:50:26.405 [erro]  client: failed to dial tailnet v2+ API  error="failed to WebSocket dial: expected handshake response status code 101 but got 502" ...        sdk_err= GET http://127.0.0.1:46789/api/v2/workspaceagents/54909b8e-b909-46fa-a33d-33afa7780731/coordinate?resume_token=*** unexpected status code 502: unexpected non-JSON response "text/plain; charset=utf-8"                 Error: server is not started         *** slogtest: log detected at level ERROR; TEST FAILURE ***    t.go:115: 2024-11-19 01:50:26.405 [erro]  client: failed to dial tailnet v2+ API  error="failed to WebSocket dial: expected handshake response status code 101 but got 502"         *** slogtest: log detected at level ERROR; TEST FAILURE ***

Those are real errors and we don't want to suppress them. You can configure the logger not to fail the test like

logger := slogtest.Make(t, &slogtest.Options{IgnoreErrors: true}).Level(slog.LevelDebug)

@ethanndickson
Copy link
Member

Okay, I think we can finally merge this?

@ethanndicksonethanndickson merged commitfbe2fa6 intomainNov 20, 2024
26 checks passed
@ethanndicksonethanndickson deleted the dean/coord-rolling-restart-test branchNovember 20, 2024 07:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ethanndicksonethanndicksonethanndickson left review comments

@spikecurtisspikecurtisspikecurtis approved these changes

Assignees

@ethanndicksonethanndickson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add e2e test for client <-> agent reconnection

4 participants

@deansheather@ethanndickson@spikecurtis@sreya
[8]ページ先頭
©2009-2025 Movatter.jp