Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: add type-safety for Storybook preview.jsx config file#14671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
buenos-nachos merged 3 commits intomainfrommes/js-file-fix
Sep 13, 2024

Conversation

@buenos-nachos
Copy link
Contributor

No issue to link – just something I noticed when working on a separate issue

Changes made

  • Added@ts-check directive and type-safe JSDoc comments to all components in ourpreview.jsx file
  • Fixed broken imports in the file (that weren't getting caught because we had no type-safety)
  • Formatted the file, and applied a few recommendations from the Biome linter

@buenos-nachosbuenos-nachos requested review froma team andBrunoQuaresma and removed request fora teamSeptember 13, 2024 16:58
@buenos-nachosbuenos-nachos self-assigned thisSep 13, 2024
Copy link
Contributor

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ty for making this

@buenos-nachosbuenos-nachos merged commit7ea8a22 intomainSep 13, 2024
@buenos-nachosbuenos-nachos deleted the mes/js-file-fix branchSeptember 13, 2024 21:26
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 13, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

1 more reviewer

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@buenos-nachosbuenos-nachos

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@buenos-nachos@BrunoQuaresma

[8]ページ先頭

©2009-2025 Movatter.jp