- Notifications
You must be signed in to change notification settings - Fork928
feat: implement organization role sync#14649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
96e4835 tod7e2ac0Compared7e2ac0 to12c7af7CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is a lot so I'll admit some of the more detailed mapping logic I glossed over, but the tests look solid 👍 🦖
| s.Logger.Debug(ctx, "OIDC roles ignored in assignment", | ||
| slog.F("ignored", ignored), | ||
| slog.F("assigned", filtered), | ||
| slog.F("user_id", user.ID), | ||
| slog.F("username", user.Username), | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
coderd/members.go Outdated
| @@ -215,6 +216,33 @@ func (api *API) putMemberRoles(rw http.ResponseWriter, r *http.Request) { | |||
| aReq.Old = member.OrganizationMember.Auditable(member.Username) | |||
| defer commitAudit() | |||
| // Keep this block scoping to prevent accidental use of the user variable. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is basically saying this should be a function imo
7139374 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
What this does
Existing deployment values configure site role sync. Organizations can now configure org role sync.
Removed existing role sync, and moved all code to
idpsyncpackage.In support of#14203