Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: get and update group IdP Sync settings#14647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 14 commits intomainfromoh-crud
Sep 16, 2024
Merged

feat: get and update group IdP Sync settings#14647

Emyrk merged 14 commits intomainfromoh-crud
Sep 16, 2024

Conversation

aslilac
Copy link
Member

No description provided.

@aslilacaslilac changed the base branch frommain tostevenmasley/org_group_syncSeptember 11, 2024 18:38
Base automatically changed fromstevenmasley/org_group_sync tomainSeptember 11, 2024 18:43
@EmyrkEmyrk marked this pull request as ready for reviewSeptember 16, 2024 15:11
Comment on lines +54 to +57
if !api.Authorize(r, policy.ActionUpdate, rbac.ResourceIdpsyncSettings.InOrg(org.ID)) {
httpapi.Forbidden(rw)
return
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Until we find another solution, I'm doing rbac checks at the api level.

@aslilac
Copy link
MemberAuthor

thanks for taking this the rest of the way! happy to see I was on the right track, but I was probably in over my head with the permissions stuff :p

Emyrk reacted with heart emoji

@EmyrkEmyrk merged commit5ed065d intomainSep 16, 2024
30 checks passed
@EmyrkEmyrk deleted the oh-crud branchSeptember 16, 2024 17:01
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 16, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@EmyrkEmyrkEmyrk approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@aslilac@Emyrk
[8]ページ先頭
©2009-2025 Movatter.jp