- Notifications
You must be signed in to change notification settings - Fork928
chore: read template tar from stdin if stdin is not a tty#14643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
ethanndickson merged 1 commit intomainfrom09-11-chore_read_template_tar_from_stdin_if_stdin_is_not_a_ttySep 12, 2024
Merged
chore: read template tar from stdin if stdin is not a tty#14643
ethanndickson merged 1 commit intomainfrom09-11-chore_read_template_tar_from_stdin_if_stdin_is_not_a_ttySep 12, 2024
+23 −16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@ethanndickson and the rest of your teammates on |
Uh oh!
There was an error while loading.Please reload this page.
deansheather approved these changesSep 11, 2024
Uh oh!
There was an error while loading.Please reload this page.
8079188
tocbc1ab9
Comparecbc1ab9
to423d43b
Compareefd532e
intomain 27 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Closes#13203.
coder templates push
currently only reads the template tar fromstdin
if the--directory
flag is set to-
. This is kind of awkward, and as seen in the attached issue, easy to miss. We can already check if the command is being piped to, so this is just a minor QOL improvement.This breaks one valid albeit odd workflow, where a confirmation is piped into the command instead of using
--yes/-y
:e.g:
would no longer work as expected.
Also updates
isTTY
toisTTYIn
, since the name suggests it could check eitherstdin
orstdout
, but it only checksstdin
, andisTTYOut
already exists.