Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: read template tar from stdin if stdin is not a tty#14643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedSep 11, 2024
edited
Loading

Closes#13203.

coder templates push currently only reads the template tar fromstdin if the--directory flag is set to-. This is kind of awkward, and as seen in the attached issue, easy to miss. We can already check if the command is being piped to, so this is just a minor QOL improvement.

This breaks one valid albeit odd workflow, where a confirmation is piped into the command instead of using--yes/-y:

e.g:

echo 'yes' | coder templates push

would no longer work as expected.

Also updatesisTTY toisTTYIn, since the name suggests it could check eitherstdin orstdout, but it only checksstdin, andisTTYOut already exists.

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@ethanndickson and the rest of your teammates onGraphiteGraphite

@ethanndicksonethanndickson marked this pull request as ready for reviewSeptember 11, 2024 12:39
@ethanndicksonethanndicksonforce-pushed the09-11-chore_read_template_tar_from_stdin_if_stdin_is_not_a_tty branch from8079188 tocbc1ab9CompareSeptember 12, 2024 03:40
@ethanndicksonethanndicksonforce-pushed the09-11-chore_read_template_tar_from_stdin_if_stdin_is_not_a_tty branch fromcbc1ab9 to423d43bCompareSeptember 12, 2024 03:54
@ethanndicksonethanndickson merged commitefd532e intomainSep 12, 2024
27 checks passed
@ethanndicksonethanndickson deleted the 09-11-chore_read_template_tar_from_stdin_if_stdin_is_not_a_tty branchSeptember 12, 2024 04:36
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 12, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Pushing a template with a symbolically linked module fails
2 participants
@ethanndickson@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp