- Notifications
You must be signed in to change notification settings - Fork929
fix: fix flake in TestWorkspaceAgentClientCoordinate_ResumeToken#14642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@spikecurtis and the rest of your teammates on |
c2df472 to9893031Comparedeansheather approved these changesSep 11, 2024
5bd19f8 intomain 27 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
fixes#14365
I bet what's going on is that in
connectToCoordinatorAndFetchResumeToken()we callCoordinate(), send a message on theCoordinateclient and then close it in rapid succession. We don't wait around for a response from the coordinator, so dRPC is likely aborting the callCoordinate()in the backend because the stream is closed before it even gets a chance.Instead of using the Coordinator to record the peer ID assigned on the API call, we can wrap the resume token provider, since we call that APIand wait for a response. This also affords the opportunity to directly assert we get called with the right token.