Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: remove tailnet v1 API support#14641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 2 commits intomainfromspike/remove-v1-tailnet
Sep 12, 2024
Merged

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedSep 11, 2024•
edited
Loading

Drops support for v1 of the tailnet API, which was the original coordination protocol where we only sent node updates, never marked them lost or disconnected.

v2 of the tailnet API went GA for CLI clients in Coder 2.8.0, so clients older than that would stop working.

@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedSep 11, 2024•
edited
Loading

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@spikecurtis and the rest of your teammates onGraphiteGraphite

@spikecurtisspikecurtis marked this pull request as ready for reviewSeptember 11, 2024 09:59
@@ -683,7 +592,13 @@ func TestPGCoordinator_Unhealthy(t *testing.T) {
logger := slogtest.Make(t, &slogtest.Options{IgnoreErrors: true}).Leveled(slog.LevelDebug)

calls := make(chan struct{})
// first call succeeds, so that our Agent will successfully connect.
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

previously, we started a pipe connection and used the v1 API over it. This eventually callsCoordinate(), but starting the pipe didn't block onCoordinate() returning.

With the v2 API, we synchronously callCoordinate() from the main test goroutine, so we need to get an initially successful heartbeat to unblock theCoordinate() call or this test would deadlock.

Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice work on the test rewriting 👍

@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedSep 12, 2024•
edited
Loading

Merge activity

  • Sep 11, 11:40 PM EDT:@spikecurtis started a stack merge that includes this pull request viaGraphite.
  • Sep 11, 11:42 PM EDT:Graphite rebased this pull request as part of a merge.
  • Sep 11, 11:56 PM EDT:@spikecurtis merged this pull request withGraphite.

@spikecurtisspikecurtis changed the base branch fromspike/legacy-agent-ip tographite-base/14641September 12, 2024 03:40
@spikecurtisspikecurtis changed the base branch fromgraphite-base/14641 tomainSeptember 12, 2024 03:40
Signed-off-by: Spike Curtis <spike@coder.com>
@spikecurtisspikecurtis merged commitd6154c4 intomainSep 12, 2024
28 of 30 checks passed
@spikecurtisspikecurtis deleted the spike/remove-v1-tailnet branchSeptember 12, 2024 03:56
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 12, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

@sreyasreyaAwaiting requested review from sreya

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@spikecurtis@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp