Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: remove legacy AgentIP address#14640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/legacy-agent-ip
Sep 12, 2024
Merged

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedSep 11, 2024
edited
Loading

Removes the support for the Agent's "legacy IP" which was a hardcoded IP address all agents used to use, before we introduced "single tailnet". Single tailnet went GA in 2.7.0.

@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedSep 11, 2024
edited
Loading

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@spikecurtis and the rest of your teammates onGraphiteGraphite

@spikecurtisspikecurtis marked this pull request as ready for reviewSeptember 11, 2024 09:56
@spikecurtisspikecurtisforce-pushed thespike/legacy-agent-ip branch 3 times, most recently from4f41732 tobc16937CompareSeptember 11, 2024 12:00
@@ -11,8 +11,7 @@ import {
} from "../helpers";
import { beforeCoderTest } from "../hooks";

// we no longer support versions prior to single tailnet: https://github.com/coder/coder/commit/d7cbdbd9c64ad26821e6b35834c59ecf85dcd9d4
const clientVersion = "v0.27.0";
const clientVersion = "v2.8.0";
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Theoretically, this should work with 2.7.0. I tried it and it doesn't work. Rather than try to debug, I just set it to 2.8.0, which is what it'll be in the PR above this one on the stack.

@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedSep 12, 2024
edited
Loading

Merge activity

@spikecurtisspikecurtis merged commitfb3523b intomainSep 12, 2024
30 checks passed
@spikecurtisspikecurtis deleted the spike/legacy-agent-ip branchSeptember 12, 2024 03:40
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

@sreyasreyaAwaiting requested review from sreya

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@spikecurtis@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp