Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: align active version terminology and link to docs#14639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dannykopping merged 4 commits intomainfromdk/active-version
Sep 11, 2024

Conversation

dannykopping
Copy link
Contributor

@dannykoppingdannykopping commentedSep 11, 2024•
edited
Loading

I found this quite confusing when I came across this feature.

image

What is the "default version"? I've changed this to "active version" which I believe is the intent here, and added a link to the documentation.

image

I also linked the docs in the CLI--require-active-version flags' help text.

Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Also need to update reference to "default version" indocs/workspaces.md

Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice!

@dannykoppingdannykopping merged commit1b5f341 intomainSep 11, 2024
30 checks passed
@dannykoppingdannykopping deleted the dk/active-version branchSeptember 11, 2024 10:25
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 11, 2024
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Post-merge 👍

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

@johnstcnjohnstcnjohnstcn left review comments

@BrunoQuaresmaBrunoQuaresmaAwaiting requested review from BrunoQuaresma

Assignees

@dannykoppingdannykopping

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@dannykopping@mafredri@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp