Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: add lint for codersdk dependencies#14638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedSep 11, 2024
edited
Loading

To avoid problems like#14633 in the future, we can recursively get all the direct, indirect, and test dependencies forcodersdk to ensure they don't include anything that requires one of our go.mod replace directives.

We could also maintain a list of 'heavy' dependencies and include that in the script, but the replace directives already include tailscale (and therefore gvisor).

e.g. whencoderdtest is imported incodersdk_test locally:

~/coder $ ./scripts/check_codersdk_imports.shERROR: codersdk cannot import the following packages being replaced in go.mod:github.com/alecthomas/chroma/v2go.opencensus.iogithub.com/tcnksm/go-httpstatgithub.com/dlclark/regexp2tailscale.comgithub.com/gliderlabs/sshgithub.com/pkg/sftpgithub.com/lib/pq

otherwise:

~/coder $ ./scripts/check_codersdk_imports.shcodersdk imports OK

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@ethanndickson and the rest of your teammates onGraphiteGraphite

@ethanndicksonethanndickson changed the titlechore: lint codersdk dependencies for tailscalechore: add lint for codersdk dependenciesSep 11, 2024
@ethanndicksonethanndicksonforce-pushed the09-11-chore_lint_codersdk_dependencies_for_tailscale branch 2 times, most recently fromb0ea2f9 to4a1728fCompareSeptember 11, 2024 06:42
@ethanndicksonethanndickson marked this pull request as ready for reviewSeptember 11, 2024 06:46
@ethanndicksonethanndicksonforce-pushed the09-11-chore_lint_codersdk_dependencies_for_tailscale branch from4a1728f to438d62bCompareSeptember 11, 2024 13:55
@ethanndicksonethanndicksonforce-pushed the09-11-chore_lint_codersdk_dependencies_for_tailscale branch from438d62b to9124b8bCompareSeptember 12, 2024 02:48
@ethanndicksonethanndicksonforce-pushed the09-11-chore_lint_codersdk_dependencies_for_tailscale branch from9124b8b to1ca5222CompareSeptember 12, 2024 03:54
@ethanndicksonethanndickson merged commit33e896d intomainSep 12, 2024
29 of 30 checks passed
@ethanndicksonethanndickson deleted the 09-11-chore_lint_codersdk_dependencies_for_tailscale branchSeptember 12, 2024 05:34
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 12, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

@coadlercoadlerAwaiting requested review from coadler

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp