- Notifications
You must be signed in to change notification settings - Fork928
chore: add lint for codersdk dependencies#14638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
ethanndickson merged 1 commit intomainfrom09-11-chore_lint_codersdk_dependencies_for_tailscaleSep 12, 2024
Merged
chore: add lint for codersdk dependencies#14638
ethanndickson merged 1 commit intomainfrom09-11-chore_lint_codersdk_dependencies_for_tailscaleSep 12, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@ethanndickson and the rest of your teammates on |
b0ea2f9
to4a1728f
Compare4a1728f
to438d62b
Comparedeansheather approved these changesSep 11, 2024
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
438d62b
to9124b8b
Compare9124b8b
to1ca5222
Compare33e896d
intomain 29 of 30 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
To avoid problems like#14633 in the future, we can recursively get all the direct, indirect, and test dependencies for
codersdk
to ensure they don't include anything that requires one of our go.mod replace directives.We could also maintain a list of 'heavy' dependencies and include that in the script, but the replace directives already include tailscale (and therefore gvisor).
e.g. when
coderdtest
is imported incodersdk_test
locally:otherwise: