Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: add navigation test for workspace details page#14629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Parkreiner merged 5 commits intomes/filter-work-2frommes/filter-work-3
Sep 16, 2024

Conversation

Parkreiner
Copy link
Member

Part 3/3 for#14435
Won't be merging in until all parts are approved.

Changes made

  • Updated test helpers and top-level app components to make it easy to mock out implementations for specific providers
  • Added test forWorkspacePage to ensure that page navigations from there to the main workspace page resolve properly and account for the organization name

Bonus

  • Cleaned up a ternary that wasn't needed

Notes

  • Really wanted to add tests for the workspace pages filter (since we don't have any yet), but getting that part of the code into a reproducible state for tests is going to be a doozy. I tried for a little bit but ended up giving up. Think it's better to punt that until we can work on finally work on cleaning up all the logic surrounding that part of the codebase

@ParkreinerParkreiner added the siteArea: frontend dashboard labelSep 10, 2024
@ParkreinerParkreiner self-assigned thisSep 10, 2024
@ParkreinerParkreiner changed the titlechore: add tests for navigating from workspace details page to workspaces pagechore: add navigation tests for workspace details pageSep 10, 2024
@ParkreinerParkreiner changed the titlechore: add navigation tests for workspace details pagechore: add navigation test for workspace details pageSep 10, 2024
Copy link
Contributor

@jaaydenhjaaydenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I really like the addition of the props forRequireAuth

LGTM

@ParkreinerParkreiner merged commit6dbfe06 intomes/filter-work-2Sep 16, 2024
23 checks passed
@ParkreinerParkreiner deleted the mes/filter-work-3 branchSeptember 16, 2024 20:35
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 16, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@jaaydenhjaaydenhjaaydenh approved these changes

Assignees

@ParkreinerParkreiner

Labels
siteArea: frontend dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Parkreiner@jaaydenh

[8]ページ先頭

©2009-2025 Movatter.jp