Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: show tags for psk provisioners#14628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 17 commits intomainfrompsk-tags
Sep 17, 2024
Merged

feat: show tags for psk provisioners#14628

aslilac merged 17 commits intomainfrompsk-tags
Sep 17, 2024

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedSep 9, 2024•
edited
Loading

Closes#14441

@aslilacaslilac linked an issueSep 13, 2024 that may beclosed by this pull request
5 tasks
@aslilacaslilac marked this pull request as ready for reviewSeptember 17, 2024 18:11
Copy link
Member

@ParkreinerParkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks like a pretty straightforward refactor to me. Approving

padding: "12px 18px",
width:310,
padding: "14px 18px",
width:375,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could thewidth be swapped out forflex-basis?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I kinda don't want them to grow tho, and disrupt the "grid"

Base automatically changed fromprovisioner-types tomainSeptember 17, 2024 21:20
@aslilacaslilac merged commit5be02a2 intomainSep 17, 2024
27 checks passed
@aslilacaslilac deleted the psk-tags branchSeptember 17, 2024 21:36
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 17, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ParkreinerParkreinerParkreiner approved these changes

@BrunoQuaresmaBrunoQuaresmaAwaiting requested review from BrunoQuaresma

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui(provisioners): show tags for PSK provisioners
2 participants
@aslilac@Parkreiner
[8]ページ先頭
©2009-2025 Movatter.jp