Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: expose current agent connections by type via prometheus#14612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedSep 9, 2024
edited
Loading

Closes#14357.

Adds a new prometheus metriccoderd_agentstats_currently_reachable_peers that includes the current number of pingable peers. The labelconnection_type can currently be eitherderp orp2p.

For example:

coderd_agentstats_currently_reachable_peers{    agent_name="main",    connection_type="derp",    template_name="docker",    username="admin",    workspace_name="workspace1"} 1

Reflects that the agentmain on the workspaceworkspace1 using thedocker template has one peer, and that peer is connected over DERP.

Additionally, updates the documentation to make it clear that--prometheus-collect-agent-stats must be set for theseagentstats metrics to be exposed oncoderd.

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@ethanndickson and the rest of your teammates onGraphiteGraphite

@ethanndicksonethanndicksonforce-pushed the09-09-feat_expose_current_agent_connections_by_type_via_prometheus branch fromab2a5aa toe00c2e5CompareSeptember 9, 2024 11:30
@ethanndicksonethanndickson marked this pull request as ready for reviewSeptember 9, 2024 11:34
@ethanndicksonethanndicksonforce-pushed the09-09-feat_expose_current_agent_connections_by_type_via_prometheus branch frome00c2e5 tofcd1392CompareSeptember 10, 2024 04:11
@ethanndicksonethanndicksonforce-pushed the09-09-feat_expose_current_agent_connections_by_type_via_prometheus branch fromfcd1392 to5c154eaCompareSeptember 10, 2024 11:41
@ethanndicksonethanndickson merged commitc8580a4 intomainSep 11, 2024
37 checks passed
@ethanndicksonethanndickson deleted the 09-09-feat_expose_current_agent_connections_by_type_via_prometheus branchSeptember 11, 2024 04:13
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 11, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@spikecurtisspikecurtisspikecurtis left review comments

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prometheus metric on p2p versus DERP connections
3 participants
@ethanndickson@spikecurtis@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp