I'm not sure this solution will be very clear for users.

IMHO we'd probably want to change thebehaviour of the button, not whether it's enabled or not:

• no changes:noop behaviour, and indicate as such in the button text
• with changes: change the color/text to indicate that a restart will happen with the new settings

WDYT@stirby?

• no changes:noop behaviour, and indicate as such in the button text

I'm not sure I understand the reasoning for having a 'submit' button that we know (and communicate) to do nothing.

• with changes: change the color/text to indicate that a restart will happen with the new settings

I think this might be overlapping with a separate issue#14319

I'm not sure I understand the reasoning for having a 'submit' button that we know (and communicate) to do nothing.

Agreed. I'm motivating for a change to the naming of the button as well.

Agreed. I'm motivating for a change to the naming of the button as well.

Okay. And just for confirmation: You'd want the button to be submittable but act as a no-op?

Yup. I'm no UX designer but that would at least be the most obvious to the user IMHO.

If I saw a button that said "Submit without changes", I'd know exactly what that meant.

If I made changes and the button turned orange and said "Restart with changes" with a little notice that said that the workspace would be restarted and any non-persistent data would be destroyed, there would similarly be no possibility for confusion, I feel.

If I saw a button that said "Submit without changes", I'd know exactly what that meant.

I can only speak for myself but I'd expect the behaviour of this to dosomething. In this scenario, would the "Cancel" button and the "Submit without change" button have any difference in behaviour?

If I made changes and the button turned orange and said "Restart with changes" with a little notice that said that the workspace would be restarted and any non-persistent data would be destroyed, there would similarly be no possibility for confusion, I feel.

I think this is more related to the other issue#14319 (I agree it should be more obvious but I think that's out of scope for this issue)

@BrunoQuaresma Do you have any opinions on what the design should be here?

@DanielleMaywood disabling the button when there are no changes is a broad use pattern and I also agree we could rename the button to make what will happen clearer. Maybe we could change to "Submit and restart" or "Apply and restart"?