- Notifications
You must be signed in to change notification settings - Fork928
fix(site): prevent 404s by removing version postfix from URLs#14601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
github-actionsbot commentedSep 9, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
cdrcommunity added a commit to coder/cla that referenced this pull requestSep 9, 2024
aslilac approved these changesSep 10, 2024
bcpeinhardt approved these changesSep 10, 2024
85cc695 intocoder:main 41 of 43 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Thank you! |
thanks for the fix! |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
I found broken links to the docs when looking at one of my locally running workspaces on the site.
Example broken link:
https://coder.com/docs/@v2.15.0+190cd1c/installI found I could fix the link by removing the postfix info. This is normally done automatically, but the existing code was only stripping out anything in the version number after a
-. Now it checks for either a-or+.Attached video for clarity.
CleanShot.2024-09-08.at.21.05.26.mp4