Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: update workspaces top bar to display org name#14596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Parkreiner merged 17 commits intomainfrommes/filter-work-1
Sep 16, 2024

Conversation

@Parkreiner
Copy link
Contributor

@ParkreinerParkreiner commentedSep 6, 2024
edited
Loading

Part 1/3 for#14435
Won't be merging in until all parts are approved.

Changes made

All changes apply to the/:user/:workspace-name/ route.

  • Updated all quota logic to use the new quota API endpoint
  • Moved the workspace schedule controls to the right of the top bar
  • Turned quota text into a link that takes a user to the/workspaces route with the search filter pre-populated with organization from the previous page
  • Updated all breadcrumb elements to use the nicer, more detailed tooltip style
  • Updated all breadcrumb segments to have a maximum width (main text gets truncated if the text length is too long, but the tooltips always display the full name)

Bonus

  • Refactored the breadcrumbs into separate components to make the main top bar definition a little easier to read
  • Fixed an accidental render mutation that crept through a previous review

Screenshots

Screenshot 2024-09-09 at 12 52 10 PM.Screenshot 2024-09-09 at 12 49 07 PM.Screenshot 2024-09-09 at 12 50 20 PM

Notes

  • We are definitely getting to the point where that top bar has too much stuff being squeezed into a single row. Kira confirmed that visual redesigns were out of scope, but I tried to define things to minimize the risks of content overflowing or breaking

@ParkreinerParkreiner self-assigned thisSep 6, 2024
</>
)}
</div>
{!isImmutable&&(
Copy link
ContributorAuthor

@ParkreinerParkreinerSep 9, 2024
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

All that changed was that, withWorkspaceScheduleControls moving to the right of the screen, I can now have everything grouped under a single check of theimmutable variable

So the parent<div> got moved inside, too, since, even if it doesn't render, the user won't notice

@Parkreiner
Copy link
ContributorAuthor

@jaaydenh Got the stories fixed, and went ahead and split the current quota story into two – one with the orgs feature, and one without

jaaydenh reacted with thumbs up emoji

Copy link
Contributor

@jaaydenhjaaydenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 👍

@ParkreinerParkreiner merged commit9102256 intomainSep 16, 2024
@ParkreinerParkreiner deleted the mes/filter-work-1 branchSeptember 16, 2024 20:17
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 16, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@jaaydenhjaaydenhjaaydenh approved these changes

Assignees

@ParkreinerParkreiner

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Parkreiner@jaaydenh

[8]ページ先頭

©2009-2025 Movatter.jp