Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: increase text contrast for 'create workspace' button#14588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Parkreiner merged 1 commit intomainfrommes/create-workspace-contrast
Sep 6, 2024

Conversation

Parkreiner
Copy link
Member

@ParkreinerParkreiner commentedSep 6, 2024
edited
Loading

Quick hotfix because some of our interactive elements werent' high-contrast enough. They're essentially the "primary action"s of their page, so it seemed better to increase the contrast, not just for accessibility, but also to help guide the eye a little bit better.

Changes made

  • Increased text contract for the "Create workspace" buttons in the/templates route

Before:
Screenshot 2024-09-05 at 10 58 13 PM

After:
Screenshot 2024-09-05 at 10 58 36 PM

Notes

  • We previously had a text color shift on hover, but even after fiddling with different transition values, I couldn't figure out a way to make sure it doesn't look janky. Just decided to remove it entirely

@ParkreinerParkreiner self-assigned thisSep 6, 2024
cdr-bot[bot]
cdr-botbot approved these changesSep 6, 2024
Copy link

@cdr-botcdr-botbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@ParkreinerParkreiner added the siteArea: frontend dashboard labelSep 6, 2024
@ParkreinerParkreiner merged commit0d60566 intomainSep 6, 2024
37 checks passed
@ParkreinerParkreiner deleted the mes/create-workspace-contrast branchSeptember 6, 2024 17:15
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 6, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@cdr-botcdr-bot[bot]cdr-bot[bot] approved these changes

Assignees

@ParkreinerParkreiner

Labels
siteArea: frontend dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@Parkreiner

[8]ページ先頭

©2009-2025 Movatter.jp