Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: group provisioners by authentication method#14580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 6 commits intomainfromgroup-provisioners
Sep 17, 2024

Conversation

@aslilac
Copy link
Member

@aslilacaslilac commentedSep 5, 2024•
edited
Loading

Closes#14459

Screenshot 2024-09-06 at 11 48 58 AM

Kira-Pilot reacted with hooray emoji
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelSep 14, 2024
@aslilacaslilac removed the staleThis issue is like stale bread. labelSep 16, 2024
@aslilacaslilac marked this pull request as ready for reviewSeptember 17, 2024 17:23
Copy link
Contributor

@ParkreinerParkreiner left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

So far so good! The UI looks really nice

I can go ahead and approve this now. Would you prefer that I do that, or wait until I get through all the other PRs first?

type,
provisioners,
}) => {
const [provisioner] = provisioners;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should there be a check to make sure that theprovisioners array isn't empty, or is that basically guaranteed not to happen?

If there are multiple provisioners, is there anything implied by the order they appear in? As in, is the first provisioner always the "main" one?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

currently, it should never be passed an emptyprovisioners array, but I'm gonna refactor this to make it nicer.

Copy link
Contributor

@ParkreinerParkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Going to go ahead and approve

@aslilacaslilac merged commitdda6bdc intomainSep 17, 2024
@aslilacaslilac deleted the group-provisioners branchSeptember 17, 2024 20:47
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 17, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@BrunoQuaresmaBrunoQuaresmaAwaiting requested review from BrunoQuaresma

1 more reviewer

@ParkreinerParkreinerParkreiner approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@aslilacaslilac

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ui(provisioners): group provisioners by authentication method

3 participants

@aslilac@Parkreiner
[8]ページ先頭
©2009-2025 Movatter.jp