Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: support multi-org group sync with runtime configuration#14578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 38 commits intomainfromstevenmasley/org_group_sync
Sep 11, 2024
Merged
Show file tree
Hide file tree
Changes from1 commit
Commits
Show all changes
38 commits
Select commitHold shift + click to select a range
99c97c2
wip
EmyrkSep 3, 2024
bfddeb6
begin group sync main work
EmyrkSep 3, 2024
f2857c6
initial implementation of group sync
EmyrkSep 3, 2024
791a059
work on moving to the manager
EmyrkSep 4, 2024
4326e9d
fixup compile issues
EmyrkSep 4, 2024
6d3ed2e
fixup some tests
EmyrkSep 4, 2024
0803619
handle allow list
EmyrkSep 4, 2024
596e7b4
WIP unit test for group sync
EmyrkSep 4, 2024
b9476ac
fixup tests, account for existing groups
EmyrkSep 4, 2024
ee8e4e4
fix compile issues
EmyrkSep 5, 2024
d5ff0f7
add comment for test helper
EmyrkSep 5, 2024
86c0f6f
handle legacy params
EmyrkSep 5, 2024
2f03e18
make gen
EmyrkSep 5, 2024
ec8092d
cleanup
EmyrkSep 5, 2024
d63727d
add unit test for legacy behavior
EmyrkSep 5, 2024
2a1769c
work on batching removal by name or id
EmyrkSep 5, 2024
640e86e
group sync adjustments
EmyrkSep 5, 2024
c544a29
test legacy params
EmyrkSep 5, 2024
476be45
add unit test for ApplyGroupDifference
EmyrkSep 5, 2024
164aeac
chore: remove old group sync code
EmyrkSep 5, 2024
986498d
switch oidc test config to deployment values
EmyrkSep 5, 2024
290cfa5
fix err name
EmyrkSep 6, 2024
c563b10
some linting cleanup
EmyrkSep 6, 2024
d2c247f
dbauthz test for new query
EmyrkSep 6, 2024
12685bd
fixup comments
EmyrkSep 6, 2024
bf0d4ed
fixup compile issues from rebase
EmyrkSep 6, 2024
f95128e
add test for disabled sync
EmyrkSep 6, 2024
88b0ad9
linting
EmyrkSep 6, 2024
6491f6a
chore: handle db conflicts gracefully
EmyrkSep 6, 2024
bd23288
test expected group equality
EmyrkSep 6, 2024
a390ec4
cleanup comments
EmyrkSep 6, 2024
a0a1c53
spelling mistake
EmyrkSep 6, 2024
a86ba83
linting:
EmyrkSep 6, 2024
0df7f28
add interface method to allow api crud
EmyrkSep 9, 2024
7a802a9
Remove testable example
EmyrkSep 11, 2024
611f1e3
fix formatting of sql, add a comment
EmyrkSep 11, 2024
7f28a53
remove function only used in 1 place
EmyrkSep 11, 2024
41994d2
make fmt
EmyrkSep 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
add interface method to allow api crud
  • Loading branch information
@Emyrk
Emyrk committedSep 9, 2024
commit0df7f28209e5b32747f7859871cfa7c954faf6f6
3 changes: 3 additions & 0 deletionscoderd/idpsync/group.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,9 @@ func (AGPLIDPSync) GroupSyncEnabled() bool {
// AGPL does not support syncing groups.
return false
}
func (s AGPLIDPSync) GroupSyncSettings() runtimeconfig.RuntimeEntry[*GroupSyncSettings] {
return s.Group
}

func (s AGPLIDPSync) ParseGroupClaims(_ context.Context, _ jwt.MapClaims) (GroupParams, *HTTPError) {
return GroupParams{
Expand Down
5 changes: 4 additions & 1 deletioncoderd/idpsync/idpsync.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,9 +36,12 @@ type IDPSync interface {
// ParseGroupClaims takes claims from an OIDC provider, and returns the params
// for group syncing. Most of the logic happens in SyncGroups.
ParseGroupClaims(ctx context.Context, mergedClaims jwt.MapClaims) (GroupParams, *HTTPError)

// SyncGroups assigns and removes users from groups based on the provided params.
SyncGroups(ctx context.Context, db database.Store, user database.User, params GroupParams) error
// GroupSyncSettings is exposed for the API to implement CRUD operations
// on the settings used by IDPSync. This entry is thread safe and can be
// accessed concurrently. The settings are stored in the database.
GroupSyncSettings() runtimeconfig.RuntimeEntry[*GroupSyncSettings]
}

// AGPLIDPSync is the configuration for syncing user information from an external
Expand Down

[8]ページ先頭

©2009-2025 Movatter.jp